Pre-install all Node.JS dependencies to make image smaller/faster #2148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since Node.JS dependencies rarely need to be changed during successive builds of the Docker image, it is way better to first install only dependencies without mwoffliner code, and then install mwoffliner itself. Any change to the codebase will hence only update few things without having to re-download again all dependencies.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## images_processing #2148 +/- ##
=====================================================
+ Coverage 75.19% 75.63% +0.43%
=====================================================
Files 41 41
Lines 3213 3213
Branches 704 704
=====================================================
+ Hits 2416 2430 +14
+ Misses 676 666 -10
+ Partials 121 117 -4 ☔ View full report in Codecov by Sentry. |
|
@benoit74 Great PR. I will test it this WE, but I would really appreciate @audiodude expertise in the review work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Node.JS dependencies rarely need to be changed during successive builds of the Docker image, it is way better to first install only dependencies without mwoffliner code, and then install mwoffliner itself. Any change to the codebase will hence only update few things without having to re-download again all dependencies.
Edit: to be merged to main once #2143 is merged