Prevent duplicate files #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
satyamtg
force-pushed
the
fix_duplicates
branch
2 times, most recently
from
b043f94 to
762ed33
Compare
rgaudin
requested changes
Aug 13, 2020
satyamtg
force-pushed
the
fix_duplicates
branch
from
762ed33 to
493426b
Compare
Have added a function |
rgaudin
approved these changes
Aug 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #104 by downloading everything to
instance_assetsinstead of downloading to different places.Also prevents creation of dummy subtitles if content was
{}, which resulted in many duplicates inzimcheckPlease do note that this prevents duplicate files on the basis of unique URLs, however there are some small number of files which have different URLs but same content, and hence are reported by
zimcheck. There's no way of identifying them without calculating a checksum. I think we shall see openzim/python-scraperlib#33 and use that instead for a small subset of files (which are basically some images underinstance_assets).