Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update VITE_API_URL to use 127.0.0.1 instead of localhost in .env.development #843

Merged
merged 1 commit into from
Apr 6, 2025

Conversation

nicolapace
Copy link
Contributor

As described in #841, unit tests are not working properly in the local development environment.

In particular, I was not able to use the autocomplete component properly during test with cypress.
Debugging I found out that inside cypress test environment I was not able to reach localhost:5000/v1.

Changing from the VITE_API_URL to use 127.0.0.1 instead of localhost in file .env.development solves the issue.

@kelson42 kelson42 requested a review from audiodude April 5, 2025 19:40
@audiodude
Copy link
Member

Again, I will state that this has never been an issue for me and is probably related to the network stack on your development computer. However, given that it's essentially a no-op change, it's fine.

Copy link

codecov bot commented Apr 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.60%. Comparing base (a149c36) to head (bc547f4).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #843   +/-   ##
=======================================
  Coverage   92.60%   92.60%           
=======================================
  Files          66       66           
  Lines        3542     3542           
=======================================
  Hits         3280     3280           
  Misses        262      262           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@audiodude audiodude merged commit 0a51f74 into openzim:main Apr 6, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants