Reduced the number of calls to generic_getLinks. #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #162 +/- ##
==========================================
+ Coverage 24.53% 24.70% +0.16%
==========================================
Files 18 19 +1
Lines 2001 2004 +3
Branches 1124 1126 +2
==========================================
+ Hits 491 495 +4
+ Misses 1510 1509 -1
Continue to review full report at Codecov.
|
MiguelRocha
changed the title
|
@MiguelRocha Do we have a ticket for that? Is that a speed-up PR? |
mgautierfr
requested changes
Sep 21, 2020
Refactored generic_getLinks to parse all src and href type links. Removed getDependencies() Make zimcheck call generic_getLinks only once
MiguelRocha
force-pushed
the
reduce_getlinks_call
branch
from
5c2533f to
9387ae7
Compare
Yes it is the first point of #134 |
mgautierfr
approved these changes
Sep 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored generic_getLinks to parse all src and href type links.
Removed getDependencies()
Make zimcheck call generic_getLinks only once