Two minor build fixes #445
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The dependency on libzim must be specified in compiler.has_header_symbol() for it to find the header in all cases (i.e., also when not installed in locations the compiler considers standard). This is essentially the same fix as was done earlier in libzim.
On FreeBSD, LLVM's libc++ also relies on pthread. zimcheck's 'meson.build' would use the same 'thread_dep' variable set in the root 'meson.build' file on building zimwriterfs, crushing the value set there in some cases, which would then be used in zimwriterfs' 'meson.build'.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.