Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

modify logger class name for locating easily #1450

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

modify logger class name for locating easily #1450

wants to merge 1 commit into from

Conversation

xiaoduanayu
Copy link

modify logger class name for locating easily, it's helpful for locating the specific code with log.

codefromthecrypt
codefromthecrypt reviewed Feb 16, 2025
View reviewed changes
Copy link
Member

@codefromthecrypt codefromthecrypt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this sounds nice, but it will break folks who have used tracer as the config until now. So, I think we need more people to 👍 this one. Make sense?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codefromthecrypt codefromthecrypt codefromthecrypt left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xiaoduanayu @codefromthecrypt