Update Apache HttpClient5 to 5.4.1 #1453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reta
force-pushed
the
update.httpclient5
branch
3 times, most recently
from
134816c to
f7d0eef
Compare
reta
commented
Feb 19, 2025
| @@ -24,8 +24,7 @@ | |||
| <main.basedir>${project.basedir}/../..</main.basedir> | |||
|
|
|||
| <!-- To obey the integration tests, we need to use the version >= 5.2 --> | |||
| <!-- TODO: pinned due to timeouts on 5.4.x on brave.httpclient5.ITTracingCachingH2ClientBuilder.cacheControl --> | |||
| <httpclient5.version>5.3.1</httpclient5.version> | |||
| <httpclient5.version>5.4.1</httpclient5.version> | |||
There was a problem hiding this comment.
@codefromthecrypt there was regression introduced into HttpCore5 5.3.3 [1] (that is used by HttpClient 5.4.2) and fixed by [2] (upcoming HttpCore5 5.3.4, I tested against the latest snapshots and things looks good). So I have pinned HttpClient5 to 5.4.1 (and we could update to 5.4.3 once released, no code changes are anticipated),
[1] apache/httpcomponents-core@98e23cb
[2] apache/httpcomponents-core@7274811
There was a problem hiding this comment.
Good research and sounds fine
reta
changed the title
reta
force-pushed
the
update.httpclient5
branch
from
f7d0eef to
d6032fd
Compare
codefromthecrypt
approved these changes
Feb 19, 2025
instrumentation/httpclient5/src/main/java/brave/httpclient5/HttpClientUtils.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update Apache HttpClient5 to 5.4.2