Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eureka: supports credentials in EUREKA_SERVICE_URL #3700

Merged
merged 2 commits into from
Jan 23, 2024

Conversation

codefromthecrypt
Copy link
Member

This adds support for credentials embedded in EUREKA_SERVICE_URL user info, as is typically done in spring cloud.

Fixes #3697

This adds support for credentials embedded in `EUREKA_SERVICE_URL` user
info, as is typically done in spring cloud.

Fixes #3697

Signed-off-by: Adrian Cole <[email protected]>
Signed-off-by: Adrian Cole <[email protected]>
@codefromthecrypt codefromthecrypt merged commit 41b4a37 into master Jan 23, 2024
13 checks passed
@codefromthecrypt codefromthecrypt deleted the finish-eureka branch January 23, 2024 04:53
@codefromthecrypt
Copy link
Member Author

thanks for the look @anuraaga!

Copy link
Member

@shakuzen shakuzen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to register to an authenticated eureka server
3 participants