cassandra: cleans up code and tests #3709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| # stop huge spam | ||
| org.slf4j.simpleLogger.log.org.testcontainers.dockerclient=off | ||
|
|
||
| # Schema install takes a while. Log basic information to prevent CI from thinking things are hung |
There was a problem hiding this comment.
this isn't really true anymore, so I matched logging config with the zipkin-dependencies stuff, despite this being simplelogger not log4j2
|
will rebase after #3710 |
This cleans up deprecation and style issues found in IntelliJ analysis. It also migrates docker tests to junit-jupiter and fixes the logging configuration which broke when we updated to SLF4J 2.x. This also updates all use of docker test images to the latest, in attempts to share base image layers. Signed-off-by: Adrian Cole <[email protected]>
codefromthecrypt
force-pushed
the
cassandra-cleanup
branch
from
daa8444 to
d8121db
Compare
|
going to merge this as master breaks occasionally due to memory limits on the elasticsearch image, which 3.0.5 fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This cleans up deprecation and style issues found in IntelliJ analysis. It also migrates docker tests to junit-jupiter and fixes the logging configuration which broke when we updated to SLF4J 2.x.
This also updates all use of docker test images to the latest, in attempts to share base image layers.