Updates to Armeria 1.27.1 and fixes Eureka VIP registration bug #3715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This updates to latest Armeria 1.27.0, which removes some tech debt. This also fixes a bug in the default behavior of Armeria, which is that it sets a `host:port` value for the VIP address in Eureka. While the `instanceId` needs to be qualified with port, the VIP address must not, as there's already a port field. Signed-off-by: Adrian Cole <[email protected]>
Signed-off-by: Adrian Cole <[email protected]>
|
tomorrow I'll raise a PR on the armeria side about the bad default on vipAddress, which shouldn't be host like http host header, rather a host like dns hostname. |
codefromthecrypt
commented
Feb 7, 2024
zipkin-server/src/test/java/zipkin2/server/internal/eureka/BaseITZipkinEureka.java
Outdated
Show resolved
Hide resolved
reta
approved these changes
Feb 7, 2024
Signed-off-by: Adrian Cole <[email protected]>
|
line/armeria#5451 should fix upstream |
codefromthecrypt
commented
Feb 7, 2024
| @@ -60,7 +59,8 @@ | |||
| "zipkin.storage.type=", // cheat and test empty storage type | |||
| "zipkin.collector.http.enabled=false", | |||
| "zipkin.query.enabled=false", | |||
| "zipkin.ui.enabled=false" | |||
| "zipkin.ui.enabled=false", | |||
| "zipkin.discovery.eureka.hostname=localhost" | |||
There was a problem hiding this comment.
I ran ./gradlew install from line/armeria#5451 and set the armeria version to what it produced (1.27.2-SNAPSHOT). Then, I removed this property and the results of the tests were expected, with my machine's hostname in the instanceId (along with the port), and my machine's hostname without the port as the vipAddress
Signed-off-by: Adrian Cole <[email protected]>
codefromthecrypt
changed the title
|
Thanks for the review @reta! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates to latest Armeria 1.27.0, which removes some tech debt. This also fixes a bug in the default behavior of Armeria, which is that it sets a
host:portvalue for the VIP address in Eureka. While theinstanceIdneeds to be qualified with port, the VIP address must not, as there's already a port field.cc @openzipkin/armeria