Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Pulsar collector #3788

Merged

Conversation

CodePrometheus
Copy link
Contributor

resolves #2297

  1. Add pulsar collector
  2. Add tests for all changes
  3. Add zipkin pulsar docker related files
  4. Add corresponding usage documents

@CodePrometheus
Copy link
Contributor Author

@reta @codefromthecrypt Excuse me, could you please help with the review when you have a moment, thanks.

@reta
Copy link
Contributor

reta commented Jan 25, 2025

@reta @codefromthecrypt Excuse me, could you please help with the review when you have a moment, thanks.

Thanks @CodePrometheus , did first round of review, looks solid! Few comments to look at, thank you

@CodePrometheus
Copy link
Contributor Author

@reta Thanks for your detailed review. I have made the corresponding fixes. Please feel free to take a look again when you have time.

@reta
Copy link
Contributor

reta commented Jan 26, 2025

@reta Thanks for your detailed review. I have made the corresponding fixes. Please feel free to take a look again when you have time.

Thank you @CodePrometheus , just a few very minor nits but LGTM otherwise, @codefromthecrypt do you have time to take a look? thank you.

@codefromthecrypt
Copy link
Member

wow! nice to see this coming around. To make sure this is usable, we need to have a sender for it. So, can you make a PR here following the existing conventions?

https://github.com/openzipkin/zipkin-reporter-java

I'll review more on this PR as I can.

Copy link
Member

@codefromthecrypt codefromthecrypt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one quick request is to pull the docker related parts into a new PR. This will allow us to merge that and reduce a "chicken or the egg" problem, where this PR depends on something published that it also uses. This also detangles reporter for the same reason.

@CodePrometheus
Copy link
Contributor Author

one quick request is to pull the docker related parts into a new PR. This will allow us to merge that and reduce a "chicken or the egg" problem, where this PR depends on something published that it also uses. This also detangles reporter for the same reason.

OK, let me remove the docker related changes from this PR, and I'll submit the pulsar related part in zipkin-reporter-java later.

@codefromthecrypt
Copy link
Member

ok also make sure you do raise another PR for the docker image here, as that needs to merge before this and the one for reporter (to get the sequence correct).

meanwhile happy new year!

codefromthecrypt pushed a commit that referenced this pull request Feb 3, 2025
Since there is no collector-pulsar module at present, compiling docker
will result in an error, so when this PR is merged, I will add
`zipkin-collector-pulsar` to the github actions in
#3788.
@codefromthecrypt
Copy link
Member

ok I re-pushed the 3.4.3 tag and marked zipkin-pulsar public. you can use it here and in the reporter when ready https://github.com/orgs/openzipkin/packages/container/package/zipkin-pulsar

@CodePrometheus
Copy link
Contributor Author

All have been updated, please take a look again when you have time, thx.

@codefromthecrypt codefromthecrypt merged commit e151986 into openzipkin:master Feb 4, 2025
15 checks passed
@codefromthecrypt
Copy link
Member

good job. next release of zipkin should be a minor bump as there's a new feature to announce. We should ready the reporter's sender for this prior to that release so that it is clear you can use this transport.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Pulsar transport
3 participants