feat: handle null targetServiceAppData (#187)

openziti · Oct 21, 2024 · 0abd17b · 0abd17b
1 parent 3474025
commit 0abd17b
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 7 deletions.
diff --git a/src/context/context.js b/src/context/context.js
@@ -219,9 +219,8 @@ class ZitiContext extends EventEmitter {
     this.targetService = options.target;
     this.targetServiceAppData = await this.getConnectAppDataByServiceName (this.targetService.service, this.targetService.scheme);
     this.targetServiceHost = await this.getConfigHostByServiceName (this.targetService.service);
-    if (isUndefined(this.targetServiceAppData)) {
-      this.targetServiceHostAndPort = `n/a`;
-    } else {
+    this.targetServiceHostAndPort = undefined;
+    if (!isUndefined(this.targetServiceAppData)) {
       this.targetServiceHostAndPort = `${this.targetServiceAppData.dst_hostname}:${this.targetServiceAppData.dst_port}`;
     }
     this.bootstrapperHost = options.bootstrapperHost;

diff --git a/src/http/readable-stream/_stream_passthrough.js b/src/http/readable-stream/_stream_passthrough.js
@@ -39,10 +39,12 @@ class PassThrough extends Transform  {
        * which leads to errors in Orion web UI.
        */
       if (!isUndefined(chunk)) {
-        let decodedChunk = new TextDecoder().decode(chunk);
-        if (decodedChunk.indexOf(this.zitiContext.targetServiceHostAndPort) != -1) {
-          decodedChunk = decodedChunk.replaceAll(this.zitiContext.targetServiceHostAndPort, this.zitiContext.bootstrapperHost);
-          chunk = new TextEncoder().encode(decodedChunk);
+        if (!isUndefined(this.zitiContext.targetServiceHostAndPort)) { // if we have a targetServiceHostAndPort
+          let decodedChunk = new TextDecoder().decode(chunk);
+          if (decodedChunk.indexOf(this.zitiContext.targetServiceHostAndPort) != -1) {
+            decodedChunk = decodedChunk.replaceAll(this.zitiContext.targetServiceHostAndPort, this.zitiContext.bootstrapperHost);
+            chunk = new TextEncoder().encode(decodedChunk);
+          }
         }
       }
     }