refinements for external auth support #1049

dovholuknf · 2024-11-25T22:08:32Z

various fixes, refinements while doing ext-auth support. brings in some changes from the other branch that was reviewed (but probably won't merge due to conflicts)

checks for only one -I param supplied,
saves the config file in the same location as the -I (config dir) now
normalizes identities to lowercase on windows to avoid copy/paste issues
change tunnel status to not save the config file (it was being written every 5s due to the ziti monitor on windows)
clean up some warnings

…iles

… multi-tun capability

…h is the normalized path to the file

fix newAddress event writing identity file

…h is the normalized path to the file

programs/ziti-edge-tunnel/windows-scripts.c

programs/ziti-edge-tunnel/process_cmd.c

programs/ziti-edge-tunnel/instance.c

programs/ziti-edge-tunnel/netif_driver/darwin/utun.c

programs/ziti-edge-tunnel/process_cmd.c

programs/ziti-edge-tunnel/windows-scripts.c

programs/ziti-edge-tunnel/ziti-edge-tunnel.c

scareything

lets just add the get_name function to the netif_driver interface pls.

…anges

…fier which is the normalized path to the file

…penziti/ziti-tunnel-sdk-c into add-identity-from-url-cert-key

dovholuknf requested a review from a team as a code owner November 25, 2024 22:08

dovholuknf added 11 commits November 26, 2024 15:48

updates to lib

f713ea1

updates to .h files

e045436

updates to netif_driver and remove config-utils.c

7e1bf48

updates to config_dir for service, remove CMakeList refs to removed f…

590c37a

…iles

add include for remove_nrpt_rules. remove backup file

0553888

changes from testing, normalize identifier on windows and prepare for…

eee306f

… multi-tun capability

implement new enrollment features, bug scrub/hunt related changes

eab1e34

updates after more testing

916dbf1

remove extraneous fprintf

c325941

changes after self-review on pr

44cce21

fix the build

c13e0a4

scareything force-pushed the add-identity-from-url-cert-key branch from 75544b7 to c13e0a4 Compare November 26, 2024 20:49

dovholuknf and others added 7 commits November 26, 2024 17:16

const char and fix config_dir reference

08963bc

go back to using lwip-contrib project (#1050)

224cb88

remove config_path. it was never set. continue to use identifier whic…

d55ae0e

…h is the normalized path to the file

Merge pull request #1052 from openziti/fix-newAddress-event

5ee5dc7

fix newAddress event writing identity file

go back to using lwip-contrib project (#1050)

709f04c

remove config_path. it was never set. continue to use identifier whic…

fead9bb

…h is the normalized path to the file

updates from review

f2e22df

scareything reviewed Dec 2, 2024

View reviewed changes

programs/ziti-edge-tunnel/process_cmd.c Outdated Show resolved Hide resolved

scareything reviewed Dec 2, 2024

View reviewed changes

programs/ziti-edge-tunnel/process_cmd.c Outdated Show resolved Hide resolved

programs/ziti-edge-tunnel/process_cmd.c Show resolved Hide resolved

programs/ziti-edge-tunnel/process_cmd.c Show resolved Hide resolved

programs/ziti-edge-tunnel/process_cmd.c Outdated Show resolved Hide resolved

scareything reviewed Dec 2, 2024

View reviewed changes

scareything reviewed Dec 3, 2024

View reviewed changes

programs/ziti-edge-tunnel/ziti-edge-tunnel.c Show resolved Hide resolved

scareything approved these changes Dec 3, 2024

View reviewed changes

dovholuknf and others added 4 commits December 3, 2024 11:36

whitespace and NULL

7548522

add get_name to netif driver per review request

04ef0f1

bump [email protected]

d78b7f5

ziti config event update

e61e7ea

dovholuknf added 30 commits December 11, 2024 11:14

updates from review

38dae9e

address PR comments

2856eb8

put the old code back

01acb1f

updates to lib

3e9b6be

rebase - updates to netif_driver and remove config-utils.c

cea4433

rebase - implement new enrollment features, bug scrub/hunt related ch…

8598a75

…anges

updates after more testing

f07f238

remove extraneous fprintf

00159b6

fix the build

c897d4e

rebase - remove config_path. it was never set. continue to use identi…

a2423ce

…fier which is the normalized path to the file

updates from review

8d93e50

rebase - add get_name to netif driver per review request

ba8f015

updates from review

96caf86

address PR comments

6fbb290

put the old code back

8f430ef

FILENAME_MAX -> PATH_MAX

be8411c

missed one

b8d8648

refactor jwtFilename to identityFilename

352f529

use FILENAME_MAX for now

99954c2

rebase - refactor jwtFilename to identityFilename

32b2056

use FILENAME_MAX for now

3a59c2d

rebased Merge branch 'add-identity-from-url-cert-key' of github.com:o…

801b74c

…penziti/ziti-tunnel-sdk-c into add-identity-from-url-cert-key

missed file and cmakelists update during merge

aaf8bc6

continuing to try to fix the rebase

13ad7fa

remove duplicated function. declare PATH_MAX if not declared

1180d67

remove another mismerged func

cc3d1da

continuing to attempt to appease the vs2022 compiler

23bc4c7

perhaps _WIN32 is not declared on vs2022 arm64

3d68242

it'd be easier if i had an arm64 windows machine

8f3dc83

let's see how MAX_PATH works.... :/

64a18b9

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refinements for external auth support #1049

refinements for external auth support #1049

dovholuknf commented Nov 25, 2024

scareything left a comment

refinements for external auth support #1049

Are you sure you want to change the base?

refinements for external auth support #1049

Conversation

dovholuknf commented Nov 25, 2024

scareything left a comment

Choose a reason for hiding this comment