Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add static builds presets (1.x) #949

Merged
merged 2 commits into from
Aug 23, 2024

Conversation

scareything
Copy link
Member

@scareything scareything commented Aug 22, 2024

closes #938
supersedes #943

@scareything scareything changed the title feat: add static builds presets feat: add static builds presets (1.x) Aug 22, 2024
@scareything scareything marked this pull request as ready for review August 22, 2024 12:19
@scareything scareything requested a review from a team as a code owner August 22, 2024 12:19
This was referenced Aug 22, 2024
@qrkourier
Copy link
Member

I'm performing a trial release in my fork before reviewing this pull request: https://github.com/qrkourier/ziti-tunnel-sdk-c/actions

@qrkourier
Copy link
Member

qrkourier commented Aug 22, 2024

@scareything Windows build error during the trial release in my fork: https://github.com/qrkourier/ziti-tunnel-sdk-c/actions/runs/10510568961/job/29119517808. The same matrix iteration for Windows x64 failed on the v2.0.0-alpha15 release run: https://github.com/openziti/ziti-tunnel-sdk-c/actions/runs/10490070998

[1/9] Creating directories for 'wintun-populate'
[1/9] Performing download step (download, verify and extract) for 'wintun-populate'
FAILED: wintun-populate-prefix/src/wintun-populate-stamp/wintun-populate-download D:/a/ziti-tunnel-sdk-c/ziti-tunnel-sdk-c/build/_deps/wintun-subbuild/wintun-populate-prefix/src/wintun-populate-stamp/wintun-populate-download 
cmd.exe /C "cd /D D:\a\ziti-tunnel-sdk-c\ziti-tunnel-sdk-c\build\_deps && D:\a\_temp\507572093\cmake-3.27.7-windows-x86_64\bin\cmake.exe -P D:/a/ziti-tunnel-sdk-c/ziti-tunnel-sdk-c/build/_deps/wintun-subbuild/wintun-populate-prefix/src/wintun-populate-stamp/download-wintun-populate.cmake && D:\a\_temp\507572093\cmake-3.27.7-windows-x86_64\bin\cmake.exe -P D:/a/ziti-tunnel-sdk-c/ziti-tunnel-sdk-c/build/_deps/wintun-subbuild/wintun-populate-prefix/src/wintun-populate-stamp/verify-wintun-populate.cmake && D:\a\_temp\507572093\cmake-3.27.7-windows-x86_64\bin\cmake.exe -P D:/a/ziti-tunnel-sdk-c/ziti-tunnel-sdk-c/build/_deps/wintun-subbuild/wintun-populate-prefix/src/wintun-populate-stamp/extract-wintun-populate.cmake && D:\a\_temp\507572093\cmake-3.27.7-windows-x86_64\bin\cmake.exe -E touch D:/a/ziti-tunnel-sdk-c/ziti-tunnel-sdk-c/build/_deps/wintun-subbuild/wintun-populate-prefix/src/wintun-populate-stamp/wintun-populate-download"
ninja: build stopped: subcommand failed.

CMake Error at D:/a/_temp/507572093/cmake-3.27.7-windows-x86_64/share/cmake-3.27/Modules/FetchContent.cmake:1662 (message):
Error:   Build step for wintun failed: 1
Call Stack (most recent call first):
  D:/a/_temp/507572093/cmake-3.27.7-windows-x86_64/share/cmake-3.27/Modules/FetchContent.cmake:1802:EVAL:2 (__FetchContent_directPopulate)
  D:/a/_temp/50[757](https://github.com/qrkourier/ziti-tunnel-sdk-c/actions/runs/10510568961/job/29119517808#step:4:777)2093/cmake-3.27.7-windows-x86_64/share/cmake-3.27/Modules/FetchContent.cmake:1802 (cmake_language)
  programs/ziti-edge-tunnel/wintun.cmake:10 (FetchContent_Populate)
  programs/ziti-edge-tunnel/CMakeLists.txt:11 (include)


-- Configuring incomplete, errors occurred!

⏱ elapsed: 836.353 seconds
Error: "'D:\a\_temp\507572093\cmake-3.27.7-windows-x86_64\bin\cmake.exe' failed with error code: '1'.
    at CMakeRunner.<anonymous> (D:\a\_actions\lukka\run-cmake\v10.6\dist\index.js:5405:23)
    at Generator.next (<anonymous>)
    at fulfilled (D:\a\_actions\lukka\run-cmake\v10.6\dist\index.js:5220:58)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
Error: run-cmake action execution failed: 'Error: "'D:\a\_temp\507572093\cmake-3.27.7-windows-x86_64\bin\cmake.exe' failed with error code: '1'.'

Copy link
Member

@qrkourier qrkourier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@scareything scareything merged commit 7a67e6a into release-1.x Aug 23, 2024
13 checks passed
@scareything scareything deleted the static-linux-builds-1dotx branch August 23, 2024 14:48
@nenkoru
Copy link

nenkoru commented Aug 23, 2024

That is awesome, guys!
Can't wait for a new release!

@scareything
Copy link
Member Author

Thanks for contributing, @nenkoru! The first release that includes static binaries is 1.1.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants