set spiffe id when generating a controller pki #2304
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qrkourier
force-pushed
the
deployments-cert-chain-trust-domain
branch
from
6c8357e
to
971d166
Compare
|
This change is not upgade-safe and I have changed the PR status to DRAFT. This change would be safe if:
|
qrkourier
commented
Aug 13, 2024
qrkourier
force-pushed
the
deployments-cert-chain-trust-domain
branch
from
efd29ca
to
786a044
Compare
|
Reverting to DRAFT status pending availability of an Identity library tag that presents only the default server cert chain. |
qrkourier
force-pushed
the
deployments-cert-chain-trust-domain
branch
from
85197d3
to
e8d3b83
Compare
|
Not solving this for existing quickstarts/deployments right now: the workaround is to set |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add SPIFFE ID to the Linux and Docker controller's certs