Mark peers as connected when accepting connections. Fixes #2785 #2786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plorenz
force-pushed
the
fix-ctrl-status-on-accept
branch
from
3599657 to
d324d4b
Compare
ekoby
reviewed
Feb 14, 2025
| @@ -817,6 +817,7 @@ func (self *impl) AcceptUnderlay(underlay channel.Underlay) error { | |||
| } | |||
|
|
|||
| peer.Version = versionInfo | |||
| peer.SigningCerts = []*x509.Certificate{underlay.Certificates()[0]} | |||
There was a problem hiding this comment.
why not take the full chain? is there a reason to take only leaf?
There was a problem hiding this comment.
Question for @andrewpmartinez maybe. I'm just copying the behavior of the dialing side to the listening side, and didn't dig too deep into what we use those certs for. If no cert is present, we don't update the db, so that's the specific issue I was fixing.
ekoby
approved these changes
Feb 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.