Missing polygon, fake jpeg, and turning off azimuth FM rate (#212)

* take care of missing polygon

* take care of exception raised by GDAL

* bump the version

* revert changes regarding SET off

* Exclude azimuth FM rate from the timing correction; bump version

* catch general errors rather than specific types of error

* except: -> except Exception: to take care of codacy issue

* remove redundant parenthesis in equation

* updates on Docker base image and label

---------

Co-authored-by: Seongsu Jeong <[email protected]>

docker/Dockerfile

@@ -1,8 +1,8 @@
-FROM oraclelinux:8
+FROM oraclelinux:8.8
 
 LABEL author="OPERA ADT" \
-    description="s1 cslc 0.3.2 point release" \
-    version="0.3.2-point"
+    description="s1 cslc 0.5.3 point release" \
+    version="0.5.3-point"
 
 # Update the base linux image to date
 # Create cache and config directory to be used for the dependencies

src/compass/utils/h5_helpers.py

@@ -633,7 +633,7 @@ def metadata_to_h5group(parent_group, burst, cfg, save_noise_and_cal=True,
                  bool(cfg.lut_params.enabled),
                  "If True, bistatic delay timing correction has been applied"),
             Meta('azimuth_fm_rate_applied',
-                 bool(cfg.lut_params.enabled),
+                 False,  # NOTE: Azimuth FM rate was turned off for OPERA production
                  "If True, azimuth FM-rate mismatch timing correction has been applied"),
             Meta('geometry_doppler_applied',
                  bool(cfg.lut_params.enabled),

src/compass/utils/helpers.py

@@ -348,10 +348,17 @@ def open_raster(filename, band=1):
         raise FileNotFoundError(err_str)
 
     try:
+        # The pythonic execption handling for GDAL can be turned on / off
+        # The flag of which can be identified by `gdal.GetUseExceptions()`
+        # In pythonic exception halding, `gdal.Open()` will raise `RuntimeError`
+        # In traditional GDAL, the function does not raise exception buy will return `None`,
+        # and the attempts to call GDAL methods will raise `AttributeError`
+
         ds = gdal.Open(filename, gdal.GA_ReadOnly)
         arr = ds.GetRasterBand(band).ReadAsArray()
         return arr
-    except AttributeError:
+
+    except Exception:
         # GDAL reads 1st 2 bytes of ENVI binary to determine file type. If 1st
         # bytes of flat binary is that of a jpeg but the binary is not then
         # GDAL throws a libjpeg runtime error. Follow specifically tries to

src/compass/utils/lut.py

@@ -80,8 +80,9 @@ def cumulative_correction_luts(burst, dem_path, tec_path,
         rg_lut_data += dry_los_tropo
 
     # Invert signs to correct for convention
-    # TO DO: add azimuth SET to LUT
-    az_lut_data = -(bistatic_delay.data + az_fm_mismatch.data)
+    #az_lut_data = -(bistatic_delay.data + az_fm_mismatch.data)
+    az_lut_data = -bistatic_delay.data
+    # NOTE: Azimuth FM rate was turned off for OPERA production
 
     rg_lut = isce3.core.LUT2d(bistatic_delay.x_start,
                               bistatic_delay.y_start,
@@ -229,11 +230,9 @@ def compute_geocoding_correction_luts(burst, dem_path, tec_path,
                                                  height[dec_slice],
                                                  ellipsoid,
                                                  geo2rdr_params)
-
-    # Resize SET to the size of the correction grid
     out_shape = bistatic_delay.data.shape
     kwargs = dict(order=1, mode='edge', anti_aliasing=True,
-                  preserve_range=True)
+                    preserve_range=True)
     rg_set = resize(rg_set_temp, out_shape, **kwargs)
     az_set = resize(az_set_temp, out_shape, **kwargs)
 

src/compass/version.py

@@ -8,6 +8,7 @@
 # release history
 Tag = collections.namedtuple('Tag', 'version date')
 release_history = (
+    Tag('0.5.3', '2023-10-05'),
     Tag('0.5.2', '2023-09-21'),
     Tag('0.5.1', '2023-09-09'),
     Tag('0.5.0', '2023-08-25'),