Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add range and azimuth range to source metadata #54

Merged
merged 5 commits into from
Jul 28, 2023

Conversation

seongsujeong
Copy link
Contributor

This PR is to add range and azimuth resolution to the source metadata.

Below are the references to compute the resolutions

Copy link
Collaborator

@gshiroma gshiroma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @seongsujeong . I have a few comments below

src/rtc/h5_prep.py Outdated Show resolved Hide resolved
src/rtc/h5_prep.py Outdated Show resolved Hide resolved
src/rtc/h5_prep.py Outdated Show resolved Hide resolved
src/rtc/h5_prep.py Outdated Show resolved Hide resolved
src/rtc/h5_prep.py Outdated Show resolved Hide resolved
src/rtc/h5_prep.py Outdated Show resolved Hide resolved
src/rtc/h5_prep.py Outdated Show resolved Hide resolved
src/rtc/h5_prep.py Outdated Show resolved Hide resolved
src/rtc/h5_prep.py Outdated Show resolved Hide resolved
src/rtc/h5_prep.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@gshiroma gshiroma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you, @seongsujeong

@gshiroma gshiroma merged commit 564f0a9 into opera-adt:main Jul 28, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants