Save the zero-Doppler spacing in meters in the product's metadata #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… azimuth pixel spacing and save it in the RTC-S1 metadata
There was a problem hiding this comment.
The code itself looks good to me, but I would like to hold this off until we come up with conclusion about the PR on s1-reader side.
Sounds good. Thank you, @seongsujeong ! |
seongsujeong
approved these changes
Mar 12, 2024
hfattahi
reviewed
Mar 13, 2024
|
HI @seongsujeong and @hfattahi , just updated this PR. The check for an empty polygon was introduced in commit 2e6eebb. |
seongsujeong
approved these changes
Mar 14, 2024
Co-authored-by: Seongsu Jeong <[email protected]>
hfattahi
approved these changes
Mar 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the RTC-S1 SAS to save the zero-Doppler spacing in meters in the products' metadata. It requires the OPERA S1-Reader version
0.2.4that provides the new attributeaverage_azimuth_pixel_spacingparsed from the S1 annotation files fieldazimuthPixelSpacing.