Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade controller-gen v0.16.1 to v0.17.0 #392

Merged
merged 1 commit into from
Jan 10, 2025

Conversation

camilamacedo86
Copy link
Contributor

No description provided.

@camilamacedo86 camilamacedo86 force-pushed the controller-gen branch 2 times, most recently from b875443 to 017aab9 Compare January 10, 2025 16:17
Copy link

codecov bot commented Jan 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 39.79%. Comparing base (e1ecd3a) to head (56b46b7).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #392   +/-   ##
=======================================
  Coverage   39.79%   39.79%           
=======================================
  Files          56       56           
  Lines        5450     5450           
=======================================
  Hits         2169     2169           
  Misses       3127     3127           
  Partials      154      154           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

openshift-ci bot commented Jan 10, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86, perdasilva

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 10, 2025
@perdasilva perdasilva self-requested a review January 10, 2025 16:52
@perdasilva
Copy link
Contributor

@camilamacedo86 can you please run make manifests format ?

@camilamacedo86
Copy link
Contributor Author

camilamacedo86 commented Jan 10, 2025

I did.
I am with some issue in my local env that is not working == I need to figure out.
it pass locally :-(

Signed-off-by: Per Goncalves da Silva <[email protected]>
@perdasilva perdasilva added this pull request to the merge queue Jan 10, 2025
Merged via the queue into operator-framework:master with commit bd94d97 Jan 10, 2025
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants