Skip to content

Update k8s 1 33 #432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 21, 2025
Merged

Update k8s 1 33 #432

merged 2 commits into from
Jun 21, 2025

Conversation

acornett21
Copy link
Contributor

@dependabot
Bump the k8s-dependencies group across 1 directory with 5 updates
caddf7f 
Bumps the k8s-dependencies group with 3 updates in the / directory: [k8s.io/api](https://github.com/kubernetes/api), [k8s.io/apiextensions-apiserver](https://github.com/kubernetes/apiextensions-apiserver) and [sigs.k8s.io/controller-runtime](https://github.com/kubernetes-sigs/controller-runtime).


Updates `k8s.io/api` from 0.32.3 to 0.33.1
- [Commits](kubernetes/api@v0.32.3...v0.33.1)

Updates `k8s.io/apiextensions-apiserver` from 0.32.3 to 0.33.1
- [Release notes](https://github.com/kubernetes/apiextensions-apiserver/releases)
- [Commits](kubernetes/apiextensions-apiserver@v0.32.3...v0.33.1)

Updates `k8s.io/apimachinery` from 0.32.3 to 0.33.1
- [Commits](kubernetes/apimachinery@v0.32.3...v0.33.1)

Updates `k8s.io/client-go` from 0.32.3 to 0.33.1
- [Changelog](https://github.com/kubernetes/client-go/blob/master/CHANGELOG.md)
- [Commits](kubernetes/client-go@v0.32.3...v0.33.1)

Updates `sigs.k8s.io/controller-runtime` from 0.20.4 to 0.21.0
- [Release notes](https://github.com/kubernetes-sigs/controller-runtime/releases)
- [Changelog](https://github.com/kubernetes-sigs/controller-runtime/blob/main/RELEASE.md)
- [Commits](kubernetes-sigs/controller-runtime@v0.20.4...v0.21.0)

---
updated-dependencies:
- dependency-name: k8s.io/api
  dependency-version: 0.33.1
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: k8s-dependencies
- dependency-name: k8s.io/apiextensions-apiserver
  dependency-version: 0.33.1
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: k8s-dependencies
- dependency-name: k8s.io/apimachinery
  dependency-version: 0.33.1
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: k8s-dependencies
- dependency-name: k8s.io/client-go
  dependency-version: 0.33.1
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: k8s-dependencies
- dependency-name: sigs.k8s.io/controller-runtime
  dependency-version: 0.21.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: k8s-dependencies
...

Signed-off-by: dependabot[bot] <[email protected]>
@codecov Codecov
Copy link

codecov bot commented Jun 3, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 25.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 38.27%. Comparing base (48d8867) to head (926ea26).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
cmd/operator-verify/manifests/cmd.go 0.00% 2 Missing ⚠️
pkg/validation/internal/multiarch.go 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #432      +/-   ##
==========================================
- Coverage   39.79%   38.27%   -1.53%     
==========================================
  Files          56       56              
  Lines        5450     5450              
==========================================
- Hits         2169     2086      -83     
- Misses       3127     3212      +85     
+ Partials      154      152       -2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@acornett21 acornett21 force-pushed the update_k8s_1_33 branch 3 times, most recently from 6939a9d to c31c4cd Compare June 3, 2025 21:07
@grokspawn
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 3, 2025
@acornett21 acornett21 mentioned this pull request Jun 3, 2025
Open
camilamacedo86
camilamacedo86 reviewed Jun 4, 2025
View reviewed changes
crds/operators.coreos.com_subscriptions.yaml
@@ -365,7 +364,6 @@ spec:
pod labels will be ignored. The default value is empty.
The same key is forbidden to exist in both mismatchLabelKeys and labelSelector.
Also, mismatchLabelKeys cannot be set when labelSelector isn't set.
This is a beta field and requires enabling MatchLabelKeysInPodAffinity feature gate (enabled by default).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we remove that?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was auto updated/generated, I don't think we have control over this language.

@acornett21 acornett21 mentioned this pull request Jun 3, 2025
Open
10 tasks
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jun 20, 2025
camilamacedo86
camilamacedo86 approved these changes Jun 21, 2025
View reviewed changes
Copy link
Contributor

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 21, 2025
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jun 21, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 21, 2025
@camilamacedo86
Copy link
Contributor

/lgtm cancel
/approved cancel

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jun 21, 2025
camilamacedo86
camilamacedo86 reviewed Jun 21, 2025
View reviewed changes
pkg/manifests/bundleloader.go
@@ -209,7 +209,7 @@ func loadBundle(csvName string, dir string) (*Bundle, error) {
}
defer fileReader.Close()

decoder := yaml.NewYAMLOrJSONDecoder(fileReader, 30)
decoder := yaml.NewYAMLToJSONDecoder(fileReader)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@acornett21 we need to keep the buffer size I think: https://github.com/kubernetes/apimachinery/blob/v0.33.2/pkg/util/yaml/decoder.go#L279

See

@openshift-merge-bot openshift-merge-bot bot merged commit c102f5c into operator-framework:master Jun 21, 2025
5 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@camilamacedo86 camilamacedo86 camilamacedo86 approved these changes

@ankitathomas ankitathomas Awaiting requested review from ankitathomas

Assignees

@camilamacedo86 camilamacedo86

@grokspawn grokspawn

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@acornett21 @grokspawn @camilamacedo86