Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add env override to subscription.md #217

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Nyefan
Copy link

@Nyefan Nyefan commented Dec 17, 2021

@openshift-ci
Copy link

openshift-ci bot commented Dec 17, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Nyefan
To complete the pull request process, please assign joelanford after the PR has been reviewed.
You can assign the PR to them by writing /assign @joelanford in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

@timflannagan timflannagan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks - I had a quick comment about whether we'd want to entertain documenting any config-related properties as their own, separate example. WDYT?

Comment on lines +42 to +45
config:
env:
- name: ARGS
value: "-v=10"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think my preference would be to have the config-related examples be isolated to their own set of examples, vs. baking it into an existing one. Any thoughts on that approach? I feels like we need to eventually translate https://github.com/operator-framework/operator-lifecycle-manager/blob/master/doc/design/subscription-config.md into the olm-docs repository.

@grokspawn grokspawn added the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants