Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📖 Update svc name to catalogd service #1365

Merged
merged 8 commits into from
Oct 10, 2024

Conversation

rashmi43
Copy link
Contributor

Description

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

@rashmi43 rashmi43 requested a review from a team as a code owner October 10, 2024 15:03
Copy link

netlify bot commented Oct 10, 2024

Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit babd001
🔍 Latest deploy log https://app.netlify.com/sites/olmv1/deploys/6708140256cedb0008b1ed40
😎 Deploy Preview https://deploy-preview-1365--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@rashmi43
Copy link
Contributor Author

@itroyano please review and merge

Copy link

codecov bot commented Oct 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.83%. Comparing base (d262e32) to head (babd001).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1365      +/-   ##
==========================================
+ Coverage   74.67%   74.83%   +0.15%     
==========================================
  Files          42       42              
  Lines        2515     2515              
==========================================
+ Hits         1878     1882       +4     
+ Misses        451      449       -2     
+ Partials      186      184       -2     
Flag Coverage Δ
e2e 56.73% <ø> (+0.15%) ⬆️
unit 52.68% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LalatenduMohanty LalatenduMohanty added this pull request to the merge queue Oct 10, 2024
@LalatenduMohanty LalatenduMohanty removed this pull request from the merge queue due to a manual request Oct 10, 2024
@LalatenduMohanty LalatenduMohanty added this pull request to the merge queue Oct 10, 2024
Merged via the queue into operator-framework:main with commit 008ca33 Oct 10, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants