🌱 Remove use of namespace in kustomize #2095
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
The use of the namespace parameter is kustomization files is very tricky. In one particular instance, we have an ordering issue with the cert-manager CA component. If not ordered correctly in the set of kustomization files, the CA component namespace will be overwritten by prior namespace directives. This eliminates that edge case, and makes the kustomization more robust. Downstream uses a different overlay, so there's no issue there. Also, add `-n` option to the install script to allow users to easily change the namespace that they install OLMv1 into. Note that the manifests don't change; so this keep everything as-is. Signed-off-by: Todd Short <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2095 +/- ##
=======================================
Coverage 73.49% 73.49%
=======================================
Files 78 78
Lines 7240 7240
=======================================
Hits 5321 5321
Misses 1567 1567
Partials 352 352
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tmshort The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
openshift-merge-bot
bot
merged commit a0717aa
into
operator-framework:main
23 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an alternative to #2088 that only includes the namespace changes. Adding the registry to the e2e manifests is causing issues with the upgrade tests. So, I want to get this one in before I look at that more closely.
The use of the namespace parameter in kustomization files is very tricky. In one particular instance, we have an ordering issue with the cert-manager CA component. If not ordered correctly in the set of kustomization files, the CA component namespace will be overwritten by prior namespace directives.
This eliminates that edge case, and makes the kustomization more robust.
Downstream uses a different overlay, so there's no issue there.
Also, add
-noption to the install script to allow users to easily change the namespace that they install OLMv1 into.Note that the manifests don't change; so this keep everything as-is.
Description
Reviewer Checklist