-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
⚠ remove olm.bundle.mediatype property and clusterextension support for plain+v0 #822
Conversation
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should probably remove the plain-v0 entries under testdata/bundles as well
(Apologies if I missed the removal - on GH mobile so it's entirely possible I missed it being removed)
ea020ed
to
12dbf79
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do we do with this demo? It seem to rely on plain+v0
bundle types. I think this PR will break the demo.
} | ||
// Assume all bundles are registry+v1 for now, since that's all we support. | ||
// If the bundle is not a registry+v1 bundle, the conversion will fail. | ||
bundleProvisioner := "core-rukpak-io-registry" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: Maybe let's get rid of bundleProvisioner
variable and of param in r.GenerateExpectedBundleDeployment
?
Will help to reduce the noise in reconcile
a little bit.
12dbf79
to
9748c03
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #822 +/- ##
==========================================
+ Coverage 64.63% 70.86% +6.22%
==========================================
Files 16 16
Lines 1315 1270 -45
==========================================
+ Hits 850 900 +50
+ Misses 403 300 -103
- Partials 62 70 +8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
I'd vote to either:
I personally am leaning towards removal since we are going to need to write new coast-to-coast documentation/tutorials for the new state of the world |
9748c03
to
89f2918
Compare
I'll remove it. I was having similar thoughts as well. |
… plain+v0 Signed-off-by: Joe Lanford <[email protected]>
89f2918
to
7a045e1
Compare
Fixes #822
Description
Reviewer Checklist