Skip to content

bump Go version #1709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

ErickRDS
Copy link

@ErickRDS ErickRDS commented Jun 30, 2025

Description of the change:
Updated the go directive in go.mod from version 1.24.3 to 1.24.4 to resolve GO-2025-3751, a vulnerability affecting crypto/tls certificate verification.

Motivation for the change:
This repository is being flagged by internal security scanners due to CVE-2025-24768, which is addressed in Go 1.24.4. Updating the Go version ensures compliance with security policies and mitigates the identified vulnerability.

Reviewer Checklist

  • Implementation matches the proposed design, or proposal is updated to match implementation
  • Sufficient unit test coverage
  • Sufficient end-to-end test coverage
  • Docs updated or added to /docs
  • Commit messages sensible and descriptive

@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 30, 2025
Copy link
Contributor

openshift-ci bot commented Jun 30, 2025

Hi @ErickRDS. Thanks for your PR.

I'm waiting for a operator-framework member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Contributor

openshift-ci bot commented Jun 30, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign grokspawn for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented Jul 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.17%. Comparing base (4ed9314) to head (048cdda).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1709   +/-   ##
=======================================
  Coverage   55.17%   55.17%           
=======================================
  Files         136      136           
  Lines       15918    15918           
=======================================
  Hits         8783     8783           
  Misses       5982     5982           
  Partials     1153     1153           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ErickRDS
Copy link
Author

ErickRDS commented Jul 1, 2025

Hi, this PR updates the Go version to address GO-2025-3751 (CVE-2025-24768).

The CI check failed due to go.mod version diff.
Could someone from the team please apply the override-go-verdiff label to unblock the workflow?

Thanks!

@camilamacedo86
Copy link
Contributor

Hi @ErickRDS

Thank you so much for your contribution 🎉
We need to wait a little to be ready to go 1.24.4
But ASAP, we will be moving on with this one.

@tmshort @grokspawn

@camilamacedo86
Copy link
Contributor

/ok-to-test

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok-to-test Indicates a non-member PR verified by an org member that is safe to test.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants