This repository has been archived by the owner on Aug 12, 2024. It is now read-only.
Fix: Overriding user defined labels #670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR fixes an issue where helm's postrenderer used to override the user defined object labels instead of merging them. Signed-off-by: Varsha Prasad Narsing <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #670 +/- ##
===========================================
- Coverage 31.94% 21.24% -10.70%
===========================================
Files 10 12 +2
Lines 479 772 +293
===========================================
+ Hits 153 164 +11
- Misses 304 583 +279
- Partials 22 25 +3
|
ncdc
approved these changes
Aug 1, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where helm's postrenderer
used to override the user defined object labels instead of merging them.