Skip to content
This repository has been archived by the owner on Aug 12, 2024. It is now read-only.

[v1alpha2] Introduce v1alpha2 APIs #713

Closed
wants to merge 1 commit into from
Closed

[v1alpha2] Introduce v1alpha2 APIs #713

wants to merge 1 commit into from

Conversation

varshaprasad96
Copy link
Member

This commit intends to introduce the new
v1alpha2 APIs

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 29, 2023
@varshaprasad96
Copy link
Member Author

/hold
This PR is to brainstorm and review the changes. Not intended to be merged for now.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 29, 2023
@varshaprasad96 varshaprasad96 changed the title [v1aplha2] Introduce v1alpha2 APIs [v1alpha2] Introduce v1alpha2 APIs Aug 29, 2023
@codecov
Copy link

codecov bot commented Aug 29, 2023 •
edited
Loading

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (e59d3f5) 19.21% compared to head (3be1ff2) 24.67%.
Report is 17 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #713      +/-   ##
==========================================
+ Coverage   19.21%   24.67%   +5.45%     
==========================================
  Files          13       14       +1     
  Lines        1046     1143      +97     
==========================================
+ Hits          201      282      +81     
- Misses        801      807       +6     
- Partials       44       54      +10

see 8 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ncdc
Copy link
Member

ncdc commented Aug 30, 2023

@varshaprasad96 thanks for starting this!

Do you want this PR to go through the full review process? I don't think we'd want to merge it with just the API changes?

@varshaprasad96
Copy link
Member Author

varshaprasad96 commented Aug 30, 2023 •
edited
Loading

@ncdc Not at all. Just wanted to push the incremental work being done, so that we have a place to discuss if this is the right path. Wasn't hoping for this to be merged so soon. At least until controller logic is re-written for these API changes and we have a rukpak demo working the way we want.

@ncdc
Copy link
Member

ncdc commented Aug 30, 2023

@varshaprasad96 do you plan to continue working on this branch to make the controller changes?

ncdc
ncdc reviewed Aug 30, 2023
View reviewed changes
api/v1alpha1/bundle_types.go Outdated Show resolved Hide resolved
api/v1alpha1/bundledeployment_types.go Outdated Show resolved Hide resolved
api/v1alpha2/bundledeployment_types.go Outdated Show resolved Hide resolved
api/v1alpha2/bundledeployment_types.go Outdated Show resolved Hide resolved
api/v1alpha2/source_types.go Outdated Show resolved Hide resolved
api/v1alpha2/source_types.go Outdated Show resolved Hide resolved
api/v1alpha2/source_types.go Outdated Show resolved Hide resolved
api/v1alpha2/source_types.go Outdated Show resolved Hide resolved
api/v1alpha2/source_types.go Outdated Show resolved Hide resolved
api/v1alpha2/bundledeployment_types.go Show resolved Hide resolved
@varshaprasad96
Copy link
Member Author

varshaprasad96 commented Sep 1, 2023 •
edited
Loading

do you plan to continue working on this branch to make the controller changes?

@ncdc No, I was hoping to make it separate. Have been working on some controller changes in a separate branch, but its not ready for review yet. Still working on cleaning up and re-writing a few things.

@varshaprasad96 varshaprasad96 force-pushed the v1alpha2-prototype branch 3 times, most recently from 2c17595 to 297e02c Compare September 6, 2023 16:03
@varshaprasad96 varshaprasad96 mentioned this pull request Sep 7, 2023
Closed
25 tasks
@varshaprasad96 varshaprasad96 linked an issue Sep 11, 2023 that may be closed by this pull request
v1alpha2 API #703
Closed
@varshaprasad96
Copy link
Member Author

Addressed existing PR comments. Will wait on #711 to go in before this.

fgiloux
fgiloux reviewed Sep 27, 2023
View reviewed changes
api/v1alpha2/source_types.go Outdated Show resolved Hide resolved
api/v1alpha2/source_types.go Outdated Show resolved Hide resolved
api/v1alpha2/source_types.go Outdated Show resolved Hide resolved
@varshaprasad96 varshaprasad96 force-pushed the v1alpha2-prototype branch 2 times, most recently from a0238b9 to 35e2b19 Compare October 10, 2023 21:42
@varshaprasad96 varshaprasad96 marked this pull request as ready for review October 10, 2023 21:42
@varshaprasad96 varshaprasad96 requested a review from a team as a code owner October 10, 2023 21:42
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 10, 2023
@varshaprasad96
[v1aplha2] Introduce v1alpha2 APIs
3be1ff2 
This commit intends to introduce the new
v1alpha2 APIs

Signed-off-by: Varsha Prasad Narsing <[email protected]>
@varshaprasad96
Copy link
Member Author

The PR is ready for review, given RFC has been accepted.

fgiloux
fgiloux reviewed Oct 11, 2023
View reviewed changes
api/v1alpha1/bundle_types.go Show resolved Hide resolved
api/v1alpha2/source_types.go Show resolved Hide resolved
api/v1alpha2/source_types.go Show resolved Hide resolved
api/v1alpha2/source_types.go Show resolved Hide resolved
@varshaprasad96 varshaprasad96 removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 11, 2023
@varshaprasad96 varshaprasad96 mentioned this pull request Oct 16, 2023
Closed
@github-actions GitHub Actions
Copy link

This PR has become stale because it has been open for 30 days with no activity. Please update this PR or remove the lifecycle/stale label before it is automatically closed in 30 days. Adding the lifecycle/frozen label will cause this PR to ignore lifecycle events.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 12, 2023
@github-actions GitHub Actions
Copy link

This PR has been closed as no updates were detected after 30 days of being stale. Please feel free to reopen this PR if necessary.

@github-actions github-actions bot added the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Dec 13, 2023
@github-actions github-actions bot closed this Dec 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@fgiloux fgiloux fgiloux approved these changes

@ncdc ncdc Awaiting requested review from ncdc

@joelanford joelanford Awaiting requested review from joelanford

@grokspawn grokspawn Awaiting requested review from grokspawn

Assignees
No one assigned
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

v1alpha2 API
5 participants
@varshaprasad96 @ncdc @joelanford @fgiloux @grokspawn