This repository has been archived by the owner on Aug 12, 2024. It is now read-only.
BundleDeployment Healthcheck #725
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joaquim Moreno Prusi <[email protected]>
Adds a "generic" healthcheck function. It returns true if all resources are healthy with nil error. It returns false if any of the resources are not healthy, the error contains the GVK + resource name, and the error message of each unhealthy resource. The current list of supported resources is: - Deployments - StatefulSets - DaemonSets - ReplicaSets - Pods - APIServices - CustomResourceDefinitions If the resource is not supported, it is assumed to be healthy. wip wip Signed-off-by: Joaquim Moreno Prusi <[email protected]>
Signed-off-by: Joaquim Moreno Prusi <[email protected]>
jmprusi
force-pushed
the
jmprusi/resource-healthcheck
branch
from
8a39ce8
to
b44839a
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #725 +/- ##
==========================================
+ Coverage 19.21% 23.75% +4.53%
==========================================
Files 13 14 +1
Lines 1046 1221 +175
==========================================
+ Hits 201 290 +89
- Misses 801 879 +78
- Partials 44 52 +8
☔ View full report in Codecov by Sentry. |
joelanford
reviewed
Sep 6, 2023
| // toErrKey returns a string that uniquely identifies a resource based on its GVK and name. | ||
| // This is used to create a map of "GVK + Resource Name" to error message. | ||
| func toErrKey(resource client.Object) string { | ||
| return fmt.Sprintf("%s.%s.%s/%s", resource.GetObjectKind().GroupVersionKind().Kind, resource.GetObjectKind().GroupVersionKind().Group, resource.GetObjectKind().GroupVersionKind().Version, resource.GetName()) |
There was a problem hiding this comment.
This needs to include namespace, in case the bundle puts the same named object in two different namespaces.
|
closed in favour of #711 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
wip