This repository has been archived by the owner on Aug 12, 2024. It is now read-only.
WIP: Create new generic bundle provisioner #773
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
do-not-merge/work-in-progress
Also, remove plain and registry bundle provisioners and move their logic into the respective bundle deployment provisioners. Signed-off-by: Joe Lanford <[email protected]>
joelanford
force-pushed
the
poc-generic-bundle-provisioner
branch
from
13fadd2 to
c37e283
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #773 +/- ##
=======================================
Coverage 20.62% 20.62%
=======================================
Files 14 14
Lines 1086 1086
=======================================
Hits 224 224
Misses 812 812
Partials 50 50 ☔ View full report in Codecov by Sentry. |
|
This PR has become stale because it has been open for 30 days with no activity. Please update this PR or remove the |
github-actions
bot
added
the
lifecycle/stale
openshift-merge-robot
added
the
needs-rebase
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, remove plain and registry bundle provisioners and move their logic into the respective bundle deployment provisioners.
We have a whole slew of e2e tests that exercise a bunch of "invalid" bundle unpacking failures that I (for now) marked as pending. That logic needs to be either moved to be tested at the bundle deployment level, where it the format-specific logic now lives, or perhaps it can be dropped or moved to unit/integration tests.
This is the idea that I mentioned in #772.