Skip to content
This repository has been archived by the owner on Aug 12, 2024. It is now read-only.

Improve error message for all namespaces #914

Merged
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions pkg/convert/registryv1.go
Original file line number Diff line number Diff line change
Expand Up @@ -148,6 +148,7 @@ func validateTargetNamespaces(supportedInstallModes sets.Set[string], installNam
if supportedInstallModes.Has(string(v1alpha1.InstallModeTypeAllNamespaces)) {
return nil
}
return fmt.Errorf("supported install modes %v do not support targeting all namespaces", sets.List(supportedInstallModes))
case set.Len() == 1 && !set.Has(""):
if supportedInstallModes.Has(string(v1alpha1.InstallModeTypeSingleNamespace)) {
return nil
Expand Down
Loading