Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide children section for milestones #15934

Draft
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

oliverguenther
Copy link
Member

Copy link
Member

@cbliard cbliard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have only reviewed behavior and not the code yet.

It works properly in these scenarios:

  • Selecting a milestone wp and going to relations tab, the children section is not visible
  • Changing a wp type from milestone to task, the children section becomes visible

It does not work properly in these scenarios:

  • Going to a Task wp, the children section of the relations is not visible. It should be visible.
    • Initially I saw it while reloading but it seems to alway be hidden as it also happens when navigating from a wp list view.
  • Changing wp type from Milestone to Task shows the children section, but then changing it to Milestone again does not hide it. It should become hidden.

That's probably why some tests are failing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2 participants