Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(store): replace go maps with gokv #431

Merged
merged 3 commits into from
Oct 20, 2023
Merged

Conversation

glimchb
Copy link
Member

@glimchb glimchb commented Oct 3, 2023

  • feat(store): replace go maps with gokv
  • feat(store): replace go maps with gokv in tests
  • fix(store): add gomap to handle NQNs

@codecov
Copy link

codecov bot commented Oct 3, 2023

Codecov Report

Merging #431 (01e2ef9) into main (4ae03d6) will decrease coverage by 6.89%.
The diff coverage is 48.50%.

@@            Coverage Diff             @@
##             main     #431      +/-   ##
==========================================
- Coverage   90.76%   83.88%   -6.89%     
==========================================
  Files           9        9              
  Lines         899      999     +100     
==========================================
+ Hits          816      838      +22     
- Misses         59      111      +52     
- Partials       24       50      +26     
Files Coverage Δ
pkg/frontend/frontend.go 57.14% <100.00%> (-5.36%) ⬇️
pkg/frontend/nvme_subsystem.go 83.88% <50.00%> (-9.02%) ⬇️
pkg/frontend/nvme_controller.go 81.64% <47.27%> (-12.00%) ⬇️
pkg/frontend/nvme_namespace.go 81.60% <47.82%> (-11.52%) ⬇️

This is temp handler until gokv will add GetAll()

Signed-off-by: Boris Glimcher <[email protected]>
@glimchb glimchb marked this pull request as ready for review October 20, 2023 16:21
@glimchb glimchb requested a review from a team as a code owner October 20, 2023 16:21
@glimchb glimchb merged commit e31f337 into opiproject:main Oct 20, 2023
16 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(store): use gokv pkg to abstract persistant store
1 participant