Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Device Identification Proposal #227

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Device Identification Proposal #227

wants to merge 4 commits into from

Conversation

dandaly
Copy link
Contributor

@dandaly dandaly commented Apr 18, 2023

No description provided.

@dandaly dandaly requested a review from a team as a code owner April 18, 2023 16:33
@dandaly
Copy link
Contributor Author

dandaly commented Apr 25, 2023

Ping? Can this be merged?

glimchb
glimchb requested changes Apr 25, 2023
View reviewed changes
Copy link
Member

@glimchb glimchb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ping? Can this be merged?

I don't think so, we are in active discussion and did not reach any conclusion yet

@dandaly
Copy link
Contributor Author

dandaly commented Apr 25, 2023

Ping? Can this be merged?

I don't think so, we are in active discussion and did not reach any conclusion yet

Point of process, we are also discussing this page: https://github.com/opiproject/opi-prov-life/blob/main/boot/REBOOT.md
I think the discussion goes better when the markdown is easily visible and reachable. Can this PR be merged in the same way as REBOOT (and other) pages that need discussion? Should we mark these markdown somehow as experimental?

I think we should have a consistent process for reviewing and merging these documents, which is separate from ratifying documents after discussion.

@dandaly dandaly requested a review from glimchb April 25, 2023 19:32
@glimchb
Copy link
Member

glimchb commented Apr 25, 2023

Should we mark these markdown somehow as experimental?

I agree. this is interesting suggestion

@dandaly
Copy link
Contributor Author

dandaly commented Apr 25, 2023

Should we mark these markdown somehow as experimental?

I agree. this is interesting suggestion

Ok, I added Experimental in BOLD in the title of the page, is this ok to merge for discussion?

The linter is failing but it is complaining about REBOOT and not my changes, not sure how that is happening.

@glimchb
Copy link
Member

glimchb commented Apr 25, 2023 •
edited
Loading

The linter is failing but it is complaining about REBOOT and not my changes, not sure how that is happening.

thanks. fixed. rebase please.

@glimchb
Copy link
Member

glimchb commented Apr 25, 2023

Nvidia shared this link today https://docs.kernel.org/networking/devlink/devlink-port.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glimchb glimchb Awaiting requested review from glimchb

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dandaly @glimchb @idandaly