-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: transtition to spdk client #875
Draft
artek-koltun
wants to merge
11
commits into
opiproject:main
Choose a base branch
from
artek-koltun:transtition-to-spdk-client
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
refactor: transtition to spdk client #875
artek-koltun
wants to merge
11
commits into
opiproject:main
from
artek-koltun:transtition-to-spdk-client
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Artsiom Koltun <[email protected]>
Signed-off-by: Artsiom Koltun <[email protected]>
Signed-off-by: Artsiom Koltun <[email protected]>
artek-koltun
force-pushed
the
transtition-to-spdk-client
branch
from
January 30, 2024 08:18
ab6947e
to
9f60d88
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #875 +/- ##
==========================================
- Coverage 74.77% 74.19% -0.59%
==========================================
Files 40 41 +1
Lines 3699 3778 +79
==========================================
+ Hits 2766 2803 +37
- Misses 845 887 +42
Partials 88 88 ☔ View full report in Codecov by Sentry. |
artek-koltun
force-pushed
the
transtition-to-spdk-client
branch
from
January 30, 2024 08:26
9f60d88
to
cf34d3d
Compare
Signed-off-by: Artsiom Koltun <[email protected]>
Signed-off-by: Artsiom Koltun <[email protected]>
Signed-off-by: Artsiom Koltun <[email protected]>
Signed-off-by: Artsiom Koltun <[email protected]>
Signed-off-by: Artsiom Koltun <[email protected]>
type name will be used as spdk.SpdkClientAdapter by other packages, and that stutters; consider calling this ClientAdapter Signed-off-by: Artsiom Koltun <[email protected]>
Signed-off-by: Artsiom Koltun <[email protected]>
Signed-off-by: Artsiom Koltun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
spdk rolled out its own client, and we can start transition to that client from our custom solution
This PR is a first step of the integration.
An adapter struct between the new and old APIs was created in order to address the following obstacles:
Opens: