Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement malloc volume #882

Merged
merged 3 commits into from
Apr 17, 2024
Merged

Conversation

moshe-shahar
Copy link
Contributor

No description provided.

@moshe-shahar moshe-shahar requested a review from a team as a code owner April 15, 2024 07:43
@moshe-shahar moshe-shahar force-pushed the moshe/backend_malloc branch 5 times, most recently from ac7845d to ffa0bb0 Compare April 15, 2024 09:26
Copy link
Contributor

@artek-koltun artek-koltun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you pls also update https://github.com/opiproject/opi-spdk-bridge/blob/main/scripts/tests.sh ? it uses some precreated mallocs, but maybe we could use our API to create our own mallocs to work with?

pkg/backend/malloc.go Show resolved Hide resolved
pkg/backend/malloc.go Show resolved Hide resolved
pkg/backend/malloc_test.go Outdated Show resolved Hide resolved
@moshe-shahar moshe-shahar force-pushed the moshe/backend_malloc branch from ffa0bb0 to b3b6ad2 Compare April 15, 2024 15:04
@moshe-shahar
Copy link
Contributor Author

Could you pls also update https://github.com/opiproject/opi-spdk-bridge/blob/main/scripts/tests.sh ? it uses some precreated mallocs, but maybe we could use our API to create our own mallocs to work with?

I updated that. but I'm not sure it's working, so you can wait with the review.

create backend volume using OPI and use it in the tests

Signed-off-by: Moshe Shahar <[email protected]>
@moshe-shahar moshe-shahar force-pushed the moshe/backend_malloc branch from b3b6ad2 to 3406c76 Compare April 17, 2024 07:06
@moshe-shahar
Copy link
Contributor Author

CI passed. please review.

Copy link
Member

@glimchb glimchb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@glimchb glimchb merged commit a0f9ef0 into opiproject:main Apr 17, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants