feat: demo doca app compiled with otel cpp #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: mohamedasifs123 <[email protected]>
Signed-off-by: mohamedasifs123 <[email protected]>
glimchb
requested changes
Feb 20, 2025
There was a problem hiding this comment.
- put in
srcordemofolder,configis not a good place for c code - add readme about how to run and you can attach those pictures from PR to readme
- please add new github actions workflow to test this (at least compile) and then we can also bring this up and see if it works in ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #6
compile DOCA with OTEL SDK and stream traces to jeager.