-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
replace progress message #412
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not right
Each place that calls function need to pass it’s own message
I'm not a reviewer by any means but a small nitpick about the commits, try and describe in a short way what you've done with the commit. All your commit messages are the same so it would be hard to discern which is which at a later time if need be. |
looks better, thanks for the contribution @mohamedasifs123 |
|
I will do squash commit |
@mohamedasifs123 looks good, please squash so we pass Also please consider moving |
Okay @glimchb |
@mohamedasifs123 great work, looks correct to me now... please add space
maybe also message need to be lowercase - don't remember... you can try |
Signed-off-by: mohamedasifs123 <[email protected]>
Yeah, thanks for suggesting local check of commitlint |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great, ready for merge
closes #333