refactor: unify http client creation #448
Conversation
Signed-off-by: Suraj Shirvankar <[email protected]>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
@glimchb I kept them seperate because there were some extra http headers (basic auth etc) being passed in the post request, no sure if that was needed in the get version. |
sztp-agent/pkg/secureagent/agent.go
Outdated
| @@ -171,3 +184,25 @@ func (a *Agent) SetContentTypeReq(ct string) { | |||
| func (a *Agent) SetProgressJSON(p ProgressJSON) { | |||
| a.ProgressJSON = p | |||
| } | |||
|
|
|||
| func NewHttpClient(bootstrapTrustAnchorCert string, deviceEndEntityCert string, devicePrivateKey string) http.Client { | |||
| caCert, _ := os.ReadFile(bootstrapTrustAnchorCert) | |||
There was a problem hiding this comment.
let's move this from agent to tls ?
so this should be separate PR or separate commit just for injection |
h0lyalg0rithm
force-pushed
the
refactor_http_client
branch
5 times, most recently
from
b8e5e6e to
0b7a567
Compare
Signed-off-by: Suraj Shirvankar <[email protected]>
h0lyalg0rithm
force-pushed
the
refactor_http_client
branch
from
0b7a567 to
48825de
Compare
|
@h0lyalg0rithm I wanna merge this please rebase ? |
|
LGTM |
Proposed changes
Unifies the httpclient used across the application.
No validation of server certificate
Types of changes
What types of changes does your code introduce to the repo? Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.