dnsmasq: Add add-mac, add-subnet and strip-subnet options #8447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdSchellevis
approved these changes
Mar 17, 2025
There was a problem hiding this comment.
@Monviech I doubted a bit about the add-subnet part, but also don't expect a lot of other valid uses-cases than sending the client ip.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #8440
The "add-subnet" option would be pretty hard to validate without a custom field type, or splitting the field up into like 2 integer and 2 Network fields (4 fields). Thus only the most probable use-case of adding the IPv4 and IPv6 client addresses was added. Even that would be hard to split up, as the documentation is a little fuzzy about only setting IPv6 for example.
This here is the simplest fix without spending too much time.