Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net/frr: Fix passive interface generation in ospf #4594

Merged
merged 1 commit into from
Mar 13, 2025
Merged

net/frr: Fix passive interface generation in ospf #4594

merged 1 commit into from
Mar 13, 2025

Conversation

Monviech
Copy link
Member

Fixes: #4590

It looks like its allowed to set this in frr.conf:

interface hn0
    ip ospf passive
interface hn0
    ip ospf area 0.0.0.0

And it will be automatically merged in vtysh running-config:

interface hn0
 ip ospf area 0.0.0.0
 ip ospf passive
exit
!

So this is the most simple fix.

@Monviech Monviech added the bug Production bug label Mar 13, 2025
@Monviech Monviech self-assigned this Mar 13, 2025
fichtner
fichtner approved these changes Mar 13, 2025
View reviewed changes
Copy link
Member

@fichtner fichtner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like it does something :)

@Monviech
Copy link
Member Author

Theres no feedback yet but its good enough for master.

@Monviech Monviech merged commit 8e95b6e into master Mar 13, 2025
@Monviech Monviech deleted the frr-passive-fix branch March 20, 2025 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fichtner fichtner fichtner approved these changes

@AdSchellevis AdSchellevis Awaiting requested review from AdSchellevis

Assignees

@Monviech Monviech

Labels
bug Production bug
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

net/frr: passive interfaces not announced on latest release
2 participants
@Monviech @fichtner