IFC-739 Remove references to account role attribute #4990
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
group/backend
CodSpeed Performance ReportMerging #4990 will not alter performanceComparing Summary
|
github-actions
bot
added
the
group/frontend
gmazoyer
force-pushed
the
gma-20241119-ifc739
branch
5 times, most recently
from
d18e252 to
8359128
Compare
pa-lem
approved these changes
Nov 21, 2024
ajtmccarty
approved these changes
Nov 21, 2024
| ]: | ||
| has_permission = False | ||
| for permission_backend in registry.permission_backends: | ||
| has_permission = await permission_backend.has_permission( |
There was a problem hiding this comment.
is a permission for ANY backend allowed or is it supposed to be ALL permission backends? either way, I think the current codes sets has_permission the value of the last call to permission_backend.has_permission, regardless of previous results
There was a problem hiding this comment.
IIRC we decided that only one backend should reply "permission granted" to allow a user to do something. That said in many places we implented it differently by checking every backends response. That's why I did this the same way, but I think we should have another PR to fix that behaviour across the whole code base.
ogenstad
approved these changes
Nov 22, 2024
gmazoyer
force-pushed
the
gma-20241119-ifc739
branch
from
8359128 to
234e55d
Compare
gmazoyer
force-pushed
the
gma-20241119-ifc739
branch
from
234e55d to
686369d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.