Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log graphql errors while testing #5041

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

LucasG0
Copy link
Contributor

@LucasG0 LucasG0 commented Nov 25, 2024

This PR replaces the use of graphql.graphql within our tests by a custom tests.helpers.graphql.graphql function that logs graphql errors. In this way, graphql server side stack traces are displayed.

@github-actions github-actions bot added the group/backend Issue related to the backend (API Server, Git Agent) label Nov 25, 2024
@LucasG0 LucasG0 force-pushed the lgu-log-graphql-errors branch from 329d858 to 7ad50a2 Compare November 25, 2024 21:51
@LucasG0 LucasG0 force-pushed the lgu-log-graphql-errors branch from 7ad50a2 to 193b754 Compare November 25, 2024 21:52
Copy link

codspeed-hq bot commented Nov 25, 2024

CodSpeed Performance Report

Merging #5041 will not alter performance

Comparing lgu-log-graphql-errors (193b754) with lgu-set-testing-local-level (21d01b0)

Summary

✅ 10 untouched benchmarks

@LucasG0 LucasG0 marked this pull request as ready for review November 26, 2024 00:25
@LucasG0 LucasG0 requested a review from a team November 26, 2024 00:25
Copy link
Contributor

@ogenstad ogenstad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice :)

@LucasG0 LucasG0 merged commit acc0887 into lgu-set-testing-local-level Nov 26, 2024
32 checks passed
@LucasG0 LucasG0 deleted the lgu-log-graphql-errors branch November 26, 2024 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
group/backend Issue related to the backend (API Server, Git Agent)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants