handle generics and generics peers correctly when deleting nodes #5133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
group/backend
CodSpeed Performance ReportMerging #5133 will not alter performanceComparing Summary
|
ajtmccarty
force-pushed
the
ajtm-12022024-generic-delete-constraint
branch
from
234ba21 to
943e693
Compare
ajtmccarty
changed the title
dgarros
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IFC-695
fix logic in node delete constraint to correctly handle relationships inherited from generic nodes
we were not correctly handling relationships in which the peer was a generic or the relationship was defined on a generic. this PR adds handling to make sure we check these relationships before deleting a node.
a follow-up PR will update the relationships on our Repository objects to use cascading deletes