Upgrade ruff=0.8.6 #5393
Upgrade ruff=0.8.6 #5393
Conversation
github-actions
bot
added
group/backend
ogenstad
force-pushed
the
pog-upgrade-ruff
branch
from
8c14089 to
7834702
Compare
CodSpeed Performance ReportMerging #5393 will not alter performanceComparing Summary
|
ogenstad
force-pushed
the
pog-upgrade-ruff
branch
from
7834702 to
d5bbba5
Compare
| "RUF051", # [*] Use `pop` instead of `key in dict` followed by `del dict[key]` | ||
| "RUF052", # Local dummy variable `_meta` is accessed | ||
| "RUF056", # [*] Avoid providing a falsy fallback to `dict.get()` in boolean test positions. The default fallback `None` is already falsy. | ||
| "RUF100", # [*] Unused `noqa` directive (non-enabled: `INP001`) |
There was a problem hiding this comment.
should we just removed INP001 from the code if it's not enabled instead of adding this exception ?
There was a problem hiding this comment.
I didn't want to make any code changes that weren't strictly required by this PR. For those with the [*] mark ruff should have auto-fix options and would be easy to do as follow up PRs.
| "UP012", # Unnecessary call to encode as UTF-8 | ||
| "UP018", # Unnecessary {literal_type} call (rewrite as a literal) | ||
| "UP031", # Use format specifiers instead of percent format | ||
| "UP035", # `typing.List` is deprecated, use `list` instead |
There was a problem hiding this comment.
Would be good to fix UP035 and UP006 right after this PR, I hope ruff is able to automatically convert everything for us
Ideally we should also convert Optional[XX] into XX | None, this will create a lot of changes but since there aren't that many changes between stable and develop right now this is our opportunity to do it
There was a problem hiding this comment.
There used to be some problems with Pydantic and using XX | None instead of Optional but I think that might have been addressed now.
There was a problem hiding this comment.
It worked in the SDK and I think the main issues where related to Python 3.9 so we should be good
Upgrade ruff and ignore new violations, also changes renamed rules.
Targets stable so that we can merge it back to develop as soon as this is merged.