Change S3 storage default_acl setting to a default value private
#5461
+2
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wvandeun
added
the
group/backend
CodSpeed Performance ReportMerging #5461 will degrade performances by 25.65%Comparing Summary
Benchmarks breakdown
|
dgarros
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since fastapi-storages v0.3.0 it requires that you set a value
AWS_DEFAULT_ACL.In its documentation however, it is specified that it is optional setting and that the default value is
private.https://github.com/aminalaee/fastapi-storages/blob/edc624fb647e128e82669f19b195e670a4714dfd/fastapi_storages/s3.py#L39
This creates a problem if an Infrahub user does not explicitly provide a value for this setting.
In this PR we set the default value for this setting to private, which is also the default value that boto3 uses.