Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix previous value bug for multiple updates on branch #5462

Merged
merged 2 commits into from
Jan 16, 2025

Conversation

ajtmccarty
Copy link
Contributor

@ajtmccarty ajtmccarty commented Jan 15, 2025

IFC-1121

fixes an issue in the diff calculation that would incorrectly set the previous value of an attribute/relationship on a branch as its previous value on the base branch (main) even if the node does not exist on main. the problem was that we needed to ignore edges with a from and to time within the diff timeframe. if something was added and then deleted within the diff timeframe, then we can ignore it.

also updates "NULL" to use the NULL_VALUE constant in a number of places

@github-actions github-actions bot added the group/backend Issue related to the backend (API Server, Git Agent) label Jan 15, 2025
Copy link

codspeed-hq bot commented Jan 15, 2025

CodSpeed Performance Report

Merging #5462 will not alter performance

Comparing ajtm-01142025-diff-previous-value-bug (a46088c) with stable (9ec036d)

Summary

✅ 10 untouched benchmarks

@ajtmccarty ajtmccarty marked this pull request as ready for review January 15, 2025 18:49
@ajtmccarty ajtmccarty requested a review from a team January 15, 2025 18:51
@ajtmccarty ajtmccarty merged commit 1e7daa0 into stable Jan 16, 2025
35 checks passed
@ajtmccarty ajtmccarty deleted the ajtm-01142025-diff-previous-value-bug branch January 16, 2025 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
group/backend Issue related to the backend (API Server, Git Agent)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants