Allow OIDC fallback to id_token for group support #5500
Merged
+235
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
group/backend
CodSpeed Performance ReportMerging #5500 will not alter performanceComparing Summary
|
ogenstad
force-pushed
the
pog-oidc-groups-from-id_token-IFC-1133
branch
2 times, most recently
from
273a00b to
2b5c2f4
Compare
dgarros
approved these changes
Jan 20, 2025
| @@ -185,3 +188,28 @@ def _validate_response(response: httpx.Response) -> None: | |||
| body=response.json(), | |||
| ) | |||
| raise GatewayError(message="Invalid response from Authentication provider") | |||
|
|
|||
|
|
|||
| async def _get_id_token_groups( | |||
There was a problem hiding this comment.
Would be good to add a unit test for this function with the expected format of the token
There was a problem hiding this comment.
I've added some tests around this function now.
ogenstad
force-pushed
the
pog-oidc-groups-from-id_token-IFC-1133
branch
from
2b5c2f4 to
cdcf22d
Compare
dgarros
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5464