Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display the computed attribute in the schema visualizer #5534

Merged
merged 21 commits into from
Jan 24, 2025

Conversation

pa-lem
Copy link
Contributor

@pa-lem pa-lem commented Jan 21, 2025

Issue: #5515

  • Add computed attributes display in schema visualizer to display the jinja2 and python transforms details
  • Ensure we can download the jinja2 template

Python Transform
image

Jijna2 Transform
image
image

@pa-lem pa-lem added type/feature New feature or request group/frontend Issue related to the frontend (React) labels Jan 21, 2025
@pa-lem pa-lem requested a review from bilalabbad January 21, 2025 14:44
@bilalabbad bilalabbad added the cd/preview Deploy preview branch label Jan 21, 2025
@ogenstad
Copy link
Contributor

Would it be cleaner if the Jinja2 template was shown in a dropdown instead of opening in its own popup?

@pa-lem
Copy link
Contributor Author

pa-lem commented Jan 22, 2025

Would it be cleaner if the Jinja2 template was shown in a dropdown instead of opening in its own popup?

how big can it be? if it can be quite long, then having it in a modal is safer but if it's always small we can have a small popover next to the eye icon

@ogenstad
Copy link
Contributor

Would it be cleaner if the Jinja2 template was shown in a dropdown instead of opening in its own popup?

how big can it be? if it can be quite long, then having it in a modal is safer but if it's always small we can have a small popover next to the eye icon

Hm, there's no actual limit on it now we should probably set something just to have some sane upper limit. I'd imagine most of them would be fairly short but you never know how much info a user would enter into it. Let's keep it as a popover for now and see if anyone else has any opinions about it later.

Comment on lines 57 to 63
<QueryParamProvider
adapter={ReactRouter6Adapter}
options={{
searchStringToObject: queryString.parse,
objectToSearchString: queryString.stringify,
}}
>
Copy link
Contributor

@bilalabbad bilalabbad Jan 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it should be in render's wrapper to prevent futur duplication

@pa-lem pa-lem merged commit 678c49e into stable Jan 24, 2025
33 checks passed
@pa-lem pa-lem deleted the ple-computed-attributes-IFC-1162 branch January 24, 2025 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cd/preview Deploy preview branch group/frontend Issue related to the frontend (React) type/feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants