Clean up around TestInfrahubDockerClient #5550
Draft
+87
−55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
group/backend
LucasG0
force-pushed
the
lgu-fix-dc-env
branch
from
0f5ffd6 to
fea8fab
Compare
CodSpeed Performance ReportMerging #5550 will not alter performanceComparing Summary
|
LucasG0
commented
Jan 22, 2025
|
|
||
| from .container import PROJECT_ENV_VARIABLES, InfrahubDockerCompose | ||
| DEFAULT_INFRAHUB_SERVER_VERSION = "latest" |
There was a problem hiding this comment.
This is a placeholder, I am not sure we should use latest here. It could be importlib.metadata.version("infrahub-testcontainers") instead so it corresponds to a close infrahub version to the sdk one.
LucasG0
force-pushed
the
lgu-fix-dc-env
branch
from
fea8fab to
b998165
Compare
LucasG0
commented
Jan 22, 2025
| @@ -28,6 +28,9 @@ class Namespace(str, Enum): | |||
| TEST = "test" | |||
|
|
|||
|
|
|||
| LOCAL_BUILD_DEFAULT_IMAGE_NAME = "local.build/opsmill/infrahub" | |||
There was a problem hiding this comment.
Use a different name than registry.opsmill.io/opsmill/infrahub to make explicit the image is not pulled from the registry
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior PR before sdk changes allowing sdk tests to run against multiple versions of infrahub. It contains some cleanup and should simplify / make explicit which version / image-tag we use while using
TestInfrahubDockerClient. So:infrahub_versionof a given test.INFRAHUB_TESTING_IMAGE_TAG(formerINFRAHUB_TESTING_IMAGE_VER) to specify which version to use from CI.It also adds a
check_skipso we can specify for specific tests whether they should be skipped depending on tested infrahub version.